From 4a70465acf5e40e9ad549039f7781b4c7694c076 Mon Sep 17 00:00:00 2001
From: xieyuschen <xieyuschen@gmail.com>
Date: Thu, 3 Oct 2024 17:20:56 +0800
Subject: [PATCH] tmp

---
 .github/workflows/miri-check.yml | 10 ++++++----
 internal/scripts/ci_run_miri.sh  | 12 +-----------
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/miri-check.yml b/.github/workflows/miri-check.yml
index b93988681..0ddc4de9a 100644
--- a/.github/workflows/miri-check.yml
+++ b/.github/workflows/miri-check.yml
@@ -13,12 +13,14 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Install Miri
-        env:
-          TARGET_BRANCH_COMMIT: ${{ github.event.pull_request.base.sha }}
         run: |
-          echo "Target branch commit: $TARGET_BRANCH_COMMIT"
           rustup toolchain install nightly --component miri
           rustup override set nightly
           cargo miri setup
-      - name: Test with Miri
+      - name: Get changed files
+        id: changed-files
+        uses: tj-actions/changed-files@v45
+      - name: List all changed files
+        env:
+          ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
         run: ./internal/scripts/ci_run_miri.sh  
\ No newline at end of file
diff --git a/internal/scripts/ci_run_miri.sh b/internal/scripts/ci_run_miri.sh
index 96073f8fe..f72bcb7d0 100755
--- a/internal/scripts/ci_run_miri.sh
+++ b/internal/scripts/ci_run_miri.sh
@@ -16,17 +16,7 @@ if [[ "$line" == \#* ]]; then
     continue
 fi          
 
-
-# set contains all changed files comparing to the $TARGET_BRANCH_COMMIT
-changes=$(git --no-pager diff --diff-filter=ACM --name-only $TARGET_BRANCH_COMMIT)
-if [[ -z $changes ]]; then
-    # when it's not a pull request,
-    # the $TARGET_BRANCH_COMMIT will be empty so changes is empty as well,
-    # skip running 'cargo miri test' as it doesn't make sense.
-    exit 0 
-fi
-
-if echo "$changes" | grep -q "$line"; then
+if echo "$ALL_CHANGED_FILES" | grep -q "$line"; then
     cd "$line" || { echo "Failed to change directory to $line"; exit 1; }
     echo "Run cargo miri test under: $(pwd)"
     cargo miri test