Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to import Metamask snap as signer with private key #64

Open
0xcoburn opened this issue Jan 18, 2024 · 4 comments
Open

Add support to import Metamask snap as signer with private key #64

0xcoburn opened this issue Jan 18, 2024 · 4 comments

Comments

@0xcoburn
Copy link

0xcoburn commented Jan 18, 2024

Wondering if we can add starkli support for a Metamask snap account, I can submit a PR, would it be any different than how you added support for Braavos and argent-X? Or should it be pretty straightforward?

@xJonathanLEI
Copy link
Owner

I have never used the Metamask snap account. Does it use an L1 private key for signing? So secp256k1?

@0xcoburn
Copy link
Author

It's the familiar Metamask user interface just compatible with starknet. you can't switch between EVM compatible chains like you can with original Metamask though so it's strictly a Starknet wallet. I'm not sure which signature algorithm it uses but I'm guessing it'd be similar to what argent-X or Braavos are using

@xJonathanLEI
Copy link
Owner

Will have to look into their contracts to see what's there then.

@0xcoburn
Copy link
Author

0xcoburn commented Jan 26, 2024

It uses the starkcurve so I think it wouldn't be much different than importing braavos or argent as a signer, but i don't know enough

https://github.com/Consensys/starknet-snap/blob/main/packages/starknet-snap/src/utils/starknetUtils.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants