Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DSL for controlling custom Docker containers #448

Closed
pun-ky opened this issue Sep 3, 2019 · 3 comments
Closed

Introduce DSL for controlling custom Docker containers #448

pun-ky opened this issue Sep 3, 2019 · 3 comments

Comments

@pun-ky
Copy link
Contributor

pun-ky commented Sep 3, 2019

right now, GAP is controlling HTTP container during environmentUp command, but the approach could be more generic. Let buildscript users to allow control other services during making environment up and restarting during environmentClean

@pun-ky pun-ky added this to the 7.2.0 milestone Sep 3, 2019
@pun-ky
Copy link
Contributor Author

pun-ky commented Sep 3, 2019

e.g Knot.x (custom container) may be controlled using this DSL / if required
wttech/gradle-aem-multi#65

@pun-ky
Copy link
Contributor Author

pun-ky commented Sep 8, 2019

DSL proposal

aem {
    environment {
        containers {
            httpd { // or 'override("httpd")'
                up {
                    // override default behavior
                }
                clean {
                    // override default behavior
                }
            }
            "knotx" { // or 'define("knotx")'
                up {
                    // exec any init commands needed
                }
                clean {
                    exec("sudo service knotx restart") // sth like that
                }
            }
        }
    }
}

up callbacks will be called during environmentUp task
and clean callbacks accordingly when environmentClesn task is running

@pun-ky pun-ky added the major label Sep 8, 2019
@pun-ky pun-ky removed this from the 7.2.0 milestone Sep 16, 2019
@pun-ky pun-ky added this to the 7.4.0 milestone Oct 6, 2019
@pun-ky pun-ky modified the milestones: 7.4.0, 8.0.0 Oct 10, 2019
@pun-ky
Copy link
Contributor Author

pun-ky commented Oct 11, 2019

final dsl image

@pun-ky pun-ky closed this as completed Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant