Add put method for Collections #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjsanger
force-pushed
the
feature/baton-4.3.1
branch
4 times, most recently
from
fe0f088
to
8f7c38c
Compare
Change defaults for checksum-related API method keywords to False in order to make behaviour and responsibility for the decision clearer. API callers are now responsible for setting these flags to True where they are needed. Separate checksum retrieval, updates and verification more clearly. Add a checkum keyword to DataObject::list. Add checksum size/consistency check for zero-length data objects.
kjsanger
force-pushed
the
feature/baton-4.3.1
branch
from
8f7c38c
to
efb5b15
Compare
Adding this parameter allows a callable to be supplied which can obtain per-file checksums during a recursive put operation. e.g. by reading from an accompanying .md5 file or by deciding, based on file size, whether to calculate checksums or to insist that an earlier process supply one pre-calculated. Improve test coverage of checksum operations.
This check make re-running tests more reliable in cases where the test teardown has failed to remove test groups from iRODS.
nerdstrike
requested changes
Sep 18, 2024
kjsanger
force-pushed
the
feature/baton-4.3.1
branch
from
640bb6f
to
0c9acba
Compare
nerdstrike
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change defaults for checksum-related API method keywords to False in order to make behaviour and responsibility for the decision clearer. API callers are now responsible for setting these flags to True where they are needed.
Separate checksum retrieval, updates and verification more clearly.
Add a checkum keyword to DataObject::list.
Add checksum size/consistency check for zero-length data objects.