Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Decorators for Logical Types #227

Open
cbelogu opened this issue Mar 19, 2024 · 2 comments
Open

Q: Decorators for Logical Types #227

cbelogu opened this issue Mar 19, 2024 · 2 comments

Comments

@cbelogu
Copy link

cbelogu commented Mar 19, 2024

Hi @wtho , thank you for this library. Quite helpful. Just wanted to know how we can achieve logical types with the current version?

        {
            name: "startTime",
            type: {
                type: "long",
                logicalType: "timestamp-millis",
            },
        },
@wtho
Copy link
Owner

wtho commented Mar 20, 2024

Hey @cbelogu!
This was only a small hobby project and I am not using it in any way anymore, so please be aware there might be bugs.
I didn't look into the logical types too much, but you should be able to extend it if you are open to dig a bit into the library.
Maybe I can also try to find some time and look into it, but I can't promise I'll be able to.

@cbelogu
Copy link
Author

cbelogu commented Mar 20, 2024

Hey @cbelogu! This was only a small hobby project and I am not using it in any way anymore, so please be aware there might be bugs. I didn't look into the logical types too much, but you should be able to extend it if you are open to dig a bit into the library. Maybe I can also try to find some time and look into it, but I can't promise I'll be able to.

Thanks for replying. My use case is a very simple one, have some workarounds to move forward so all good for now. I'll also look at submitting a PR when I get some time (🤞 )

Also noticed https://www.npmjs.com/package/avro-decorators-es?activeTab=versions and thought this is being revived 😁
Thanks again @wtho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants