Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update OAuth2-dynamic-client-registration document #2113

Open
nilasini opened this issue Oct 6, 2020 · 0 comments
Open

Need to update OAuth2-dynamic-client-registration document #2113

nilasini opened this issue Oct 6, 2020 · 0 comments
Assignees

Comments

@nilasini
Copy link
Contributor

nilasini commented Oct 6, 2020

Description:
Issue1

In document [1] Updates an OAuth2 application sample request doesn't have the client id. It should be changed as below.

curl -X PUT -H "Authorization: Basic YWRtaW46YWRtaW4=" -H
"Content-Type: application/json" -d '{
  "redirect_uris":["https://client.example.org/callback"],
  "client_name": "application_1",
  "grant_types": ["password"] }'
"https://localhost:9443/api/identity/oauth2/dcr/v1.1/register/client_id"

Issue2
In document[1] Registers an OAuth2 application sample request contains the version as v1.0 but it should be changed to v1.1 as below.

curl -k -X POST -H "Authorization: Basic YWRtaW46YWRtaW4=" -H 
"Content-Type: application/json" -d '{
 "client_name": "application_test",
 "grant_types": ["password"], 
 "ext_param_client_id":"provided_client_id0001", 
 "ext_param_client_secret":"provided_client_secret0001" }' 
"https://localhost:9443/api/identity/oauth2/dcr/v1.1/register"

Get OAuth2 application information is duplicated by url is having https://docs.wso2.com/display/IS590/apidocs/OAuth2-dynamic-client-registration/#!/operations#OAuth2DCR#getApplicationByName and https://docs.wso2.com/display/IS590/apidocs/OAuth2-dynamic-client-registration/#!/operations#OAuth2DCR#getApplication . But API requests and responses are the same. Seems something is missing.

[1] https://docs.wso2.com/display/IS590/apidocs/OAuth2-dynamic-client-registration/#!/operations#OAuth2DCR#updateApplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants