Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly validate the release workflow for deploying the script into WP Rocket #24

Open
wordpressfan opened this issue Aug 23, 2024 · 0 comments

Comments

@wordpressfan
Copy link
Collaborator

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version Yes
  • Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug
We face an error when releasing rocket scripts and it's related to deploying the dist scripts into WP Rocket and this maybe because of the WPR token that is needed there, also I think there is a problem in branch names so here we need to checkout a branch and create a PR to merge this branch into develop, so we need to validate the whole process.

To Reproduce
Steps to reproduce the behavior:

  1. Release a release
  2. it will fail with an error like this one: https://github.com/wp-media/rocket-scripts/actions/runs/10487786041/job/29048911355

Expected behavior
It should work properly

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant