Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run should rerendere the preview even if there is no code #873

Open
sonnyp opened this issue Jan 29, 2024 · 4 comments
Open

Run should rerendere the preview even if there is no code #873

sonnyp opened this issue Jan 29, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Jan 29, 2024

Currently we "return" if there is no code.

But we should at least rerender the preview in case auto reload is diabled.

@sonnyp sonnyp added the bug Something isn't working label Jan 30, 2024
@urffsamhunt
Copy link

Was working on it. Is replacing the empty source code with placeholder empty functions or comments a viable solution? If yes, then I have it ready.

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 19, 2024

I don't understand the question. Do you want to open a draft PR? Maybe that will clarify.

@urffsamhunt
Copy link

Okay, I will send a PR by tomorrow

@urffsamhunt
Copy link

I could make it work by simply passing a comment for the 'text' var but for Vala, Rust and Python, had to edit the text buffer which also reflects in the source code whenever you press run (line 275 in PR). Perhaps a better solution would be to directly manipulate the compiler calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants