Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ESLint and Prettier on SCSS files during pre-commit hook #17

Closed
egiurleo opened this issue Oct 6, 2021 · 6 comments · Fixed by #194
Closed

Run ESLint and Prettier on SCSS files during pre-commit hook #17

egiurleo opened this issue Oct 6, 2021 · 6 comments · Fixed by #194
Assignees
Labels

Comments

@egiurleo
Copy link
Contributor

egiurleo commented Oct 6, 2021

Currently, we have ESLint and Prettier running on js and css files during pre-commit, but we recently started using scss files. I would like ESLint and Prettier to run on those files as well so they're properly formatted and free from issues!

@egiurleo
Copy link
Contributor Author

egiurleo commented Oct 7, 2021

@mairagee524 Yes absolutely!

@egiurleo
Copy link
Contributor Author

Hi, @mairagee524! Are you still planning to work on this?

@egiurleo
Copy link
Contributor Author

egiurleo commented Jan 7, 2022

Hi @mairagee524, I'm going to unassign you from this issue for now. If you're still interested in working on it, please let me know and I'll re-assign you.

@Yogeshp0012
Copy link
Contributor

Is this open to work ? If yes please assign it to me.

@Yogeshp0012
Copy link
Contributor

Hi @egiurleo and @luciagirasoles, you have commented that eslint and prettier run on css and js files. But I can see the precommit hook to be only on ".{js,jsx,json,md,html}" for prettier and ".{js,jsx,ts,tsx}" for eslint. I do not see any CSS files added here. Should I include both CSS and SCSS?

@luciagirasoles
Copy link
Collaborator

Hi @Yogeshp0012 We had .css files instead of the current .scss files by the time this issue was created. It would be useful to include both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants