-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ESLint and Prettier on SCSS files during pre-commit hook #17
Comments
@mairagee524 Yes absolutely! |
Hi, @mairagee524! Are you still planning to work on this? |
Hi @mairagee524, I'm going to unassign you from this issue for now. If you're still interested in working on it, please let me know and I'll re-assign you. |
Is this open to work ? If yes please assign it to me. |
Hi @egiurleo and @luciagirasoles, you have commented that eslint and prettier run on css and js files. But I can see the precommit hook to be only on ".{js,jsx,json,md,html}" for prettier and ".{js,jsx,ts,tsx}" for eslint. I do not see any CSS files added here. Should I include both CSS and SCSS? |
Hi @Yogeshp0012 We had |
Currently, we have ESLint and Prettier running on js and css files during pre-commit, but we recently started using scss files. I would like ESLint and Prettier to run on those files as well so they're properly formatted and free from issues!
The text was updated successfully, but these errors were encountered: