Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how (not) to upgrade OpenSaas #240

Open
Martinsos opened this issue Jul 19, 2024 · 6 comments
Open

Explain how (not) to upgrade OpenSaas #240

Martinsos opened this issue Jul 19, 2024 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Martinsos
Copy link
Member

We had a couple of questions how to best upgrade existing OpenSaas project when new version comes out. We should make it clear you are not really meant to easily upgrade it, but that you might want to cherry-pick changes that you like, as it is a starter project.

@Martinsos Martinsos added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 19, 2024
@marcoeg
Copy link

marcoeg commented Jul 20, 2024

Thanks for the clarification. Please recommend the best course of action in creating a new project. Is the wasp new and then selecting saas generating the same repo as forking the latest open-saas repo straight on? Let me take the opportunity to also let you know that the difference between the saas template, the saas demo code and the saas template diff, is quite confusing. In any case, this is a great project you are doing in addition to Wasp and it deserves full credit. I am in the process to start at least two projects based on it. Happy to support the initiative in any way I can, including subscribing to your paid services.

@Martinsos
Copy link
Member Author

wasp new -t saas is the way to go! Not cloning the repo directly.

template vs demo code vs docs -> yup that is confusing indeed, atlhgouh it is aimed for us core developers, you as an opensaas user shouldn't have to worry about that! We are not yet sure if we will stick with the app_diff approach, it is a bit uncommon approach, something we are experimenting with.
How did you end up looking into demo app / diffs?

@marcoeg
Copy link

marcoeg commented Jul 22, 2024

Got it. Thank you for the reply. I have been looking at the repo because of the relatively high number of commits. An indication that there is still work in progress. Generating a new saas project from the CLI, what is the suggested way to merge the new commits into the project?

@Martinsos
Copy link
Member Author

Thanks for letting me know! Ah yes we are always improving something :). That doesn't neccesarily mean that current version is in bad shape, just that we are getting new ideas how to do stuff better. We are also keeping it up to date with new versions of Wasp.

Merging new commits -> we don't recommend doing it, opensaas is not meant to be updated, it is a starter. If you really do want to pull in the changes, it is best to do it manually -> take a look at the new code (either in template/ or by creating new project on your machine) and pick what you like. Or alternatively go the opposite direction: create new fresh project from CLI and carry over your own code from older project, whatever works easier.

@marcoeg
Copy link

marcoeg commented Jul 23, 2024

Okay. May I suggest to adopt at some point the idea of releases to facilitate such process? If nothing else, having release notes and release dates helps in understanding whether updating may be helping an existing application or not and the cherry picking process you are referring to. Cheers.

@Martinsos
Copy link
Member Author

@marcoeg yes that will probably make sense in the future! We still haven't figured out exactly how we want to do the releases, but we will probably do it. Here is na issue for it, and I linked to your comment: #62 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants