Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sanitising usernames and passwords used for the amp-http proxy #20

Open
brendonj opened this issue Jul 27, 2018 · 0 comments
Open

Comments

@brendonj
Copy link
Contributor

As of aeea62a the amp-http test reports the proxy server used (if any), which can possibly leak sensitive information. Consider removing usernames and passwords before sending the results onto the network. Could the proxy address also be considered sensitive?

The proxy server is not currently a stream descriptor in nntsc, but probably should be so that tests using a proxy can be identified and more easily compared with those not using a proxy. This means something needs to be reported about proxy usage (maybe a boolean flag is good enough?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant