Prevent overwriting existing wakatime-project files #1104
Merged
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
approved these changes
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #1104 +/- ##
===========================================
- Coverage 63.12% 63.11% -0.02%
===========================================
Files 383 383
Lines 16562 16565 +3
===========================================
Hits 10455 10455
- Misses 5539 5541 +2
- Partials 568 569 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual bugfix is here:
https://github.com/wakatime/wakatime-cli/pull/1104/files#diff-44583ee0c75a940c6992cc809657633fb3b289b0d10dccc3f0574ba132f93ad0R312
Also creates the offline db, log file, and wakatime-project file with
0644permission instead of0600.The rest of the changes are just cleanup.