Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream change from Trusted Types #1709

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 13, 2024

Changes register to take a union of (TrustedScriptURL or USVString) rather than just a USVString.

Updates the register method steps to call Get Trusted Type compliant string

Tested in https://wpt.live/trusted-types/WorkerGlobalScope-importScripts.html

Fixes #1710


Preview | Diff

@lukewarlow
Copy link
Member Author

@domenic seeing as you've looked at some of the other upstreaming PRs, I don't suppose you have review rights on this spec do you?

@domenic
Copy link
Contributor

domenic commented Apr 4, 2024

I do not, sorry! @mkruisselbrink is the active editor.

@lukewarlow lukewarlow marked this pull request as draft April 4, 2024 14:10
@lukewarlow lukewarlow changed the title Upstream IDL change from Trusted Types Upstream change from Trusted Types Apr 22, 2024
@lukewarlow lukewarlow marked this pull request as ready for review April 22, 2024 13:33
Changes register to take a union of (TrustedScriptURL or USVString) rather than just a USVString.

Updates the register method steps to call Get Trusted Type compliant string
Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the slow response, this lgtm

@mkruisselbrink mkruisselbrink merged commit 8ac9c66 into w3c:main Apr 30, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 30, 2024
SHA: 8ac9c66
Reason: push, by mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lukewarlow lukewarlow deleted the trusted-types branch April 30, 2024 22:31
@lukewarlow
Copy link
Member Author

No worries, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream changes from Trusted Types
3 participants