From a04378be7149fe4f57b2003764621389160b72d9 Mon Sep 17 00:00:00 2001 From: vwh Date: Wed, 16 Oct 2024 04:40:02 +0300 Subject: [PATCH] refactor: small refactor --- src/App.tsx | 1 - src/components/database/page-select.tsx | 1 + src/components/database/query-textarea.tsx | 1 - src/components/database/upper-section.tsx | 18 ++++-------------- src/components/settings/theme-mode-toggle.tsx | 2 +- 5 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/App.tsx b/src/App.tsx index b18cd65..e2ffb0b 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -24,7 +24,6 @@ const areEqual = ( return prevProps.isDatabaseLoaded === nextProps.isDatabaseLoaded; }; -// Memoize DBTable with custom comparison function const MemoizedDBTable = memo(DBTable, areEqual); const MemoizedUploadFile = memo(UploadFile); const MemoizedUrlFetch = memo(UrlFetch); diff --git a/src/components/database/page-select.tsx b/src/components/database/page-select.tsx index d5370a5..a0b49d3 100644 --- a/src/components/database/page-select.tsx +++ b/src/components/database/page-select.tsx @@ -25,6 +25,7 @@ export default function PageSelect({ () => Math.ceil(totalRows / rowsPerPage), [totalRows, rowsPerPage] ); + const currentPage = useMemo( () => Math.ceil(page / rowsPerPage) + 1, [page, rowsPerPage] diff --git a/src/components/database/query-textarea.tsx b/src/components/database/query-textarea.tsx index e36f291..b8a5a22 100644 --- a/src/components/database/query-textarea.tsx +++ b/src/components/database/query-textarea.tsx @@ -198,7 +198,6 @@ export default function QueryTextarea({ columnNames }: QueryTextareaProps) { return ( 0) { setSavedColumns(columns); } - }, [selectedTableName, columns]); + }, [columns]); const handleQueryRemove = useCallback(() => { setQueryError(null); @@ -116,14 +115,7 @@ export default function DBTable() { ), - [ - customQuery, - handleCustomQuery, - handleQueryRemove, - handleResetPage, - page, - savedColumns - ] + [handleCustomQuery, handleQueryRemove, handleResetPage, page, savedColumns] ); const MemoizedTableContent = useMemo(() => { @@ -150,7 +142,6 @@ export default function DBTable() { columns, selectedTableName, tableSchemas, - filters, savedColumns ]); @@ -164,7 +155,6 @@ export default function DBTable() {
- {/* Use MemoizedTableSelect instead of TableSelect */}
{MemoizedExportButtonsComponent} diff --git a/src/components/settings/theme-mode-toggle.tsx b/src/components/settings/theme-mode-toggle.tsx index 5045720..ff383af 100644 --- a/src/components/settings/theme-mode-toggle.tsx +++ b/src/components/settings/theme-mode-toggle.tsx @@ -67,7 +67,7 @@ export default function ThemeModeToggle() { )} ), - [theme] + [theme, toggleTheme] ); return MemoizedThemeButton;