Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't overwrite SASS variables #10

Open
pixelpeter opened this issue May 29, 2017 · 1 comment
Open

Can't overwrite SASS variables #10

pixelpeter opened this issue May 29, 2017 · 1 comment

Comments

@pixelpeter
Copy link

I'm overwriting my primary color $primary sass variable like it's defined in the documentation of http://bulma.io/documentation/overview/customize/ using the node installed version of bulma and vue-bulma-tooltip

// Import the initial variables
@import "node_modules/bulma//sass/utilities/initial-variables";

// Set your own initial variables
$primary: #72d0eb

//  Import the rest of Bulma
@import "../bulma"

The color change will be effective on my own Elements and Components like e.g. a button.

<button class="button is-primary">

But if I want to have the tooltip the same color as the button by using tooltip--primary the tooltip will have the original primary color

<button class="button is-primary tooltip tooltip--primary">
    <span>info</span>
</button>

I was wondering if this is because you import ~bulma/sass/utilities/variables in the style.scssof the tooltip component instead of ~bulma/sass/utilities/initial-variables.

I also asked @jgthms of bulma framework about the purpose of this file:
jgthms/bulma#769

@pixelpeter pixelpeter changed the title Can't overwrite vars Can't overwrite SASS variables May 29, 2017
@pixelpeter
Copy link
Author

As stated by @jgthm from bulma the file ~bulma/sass/utilities/variables is deprecated.
jgthms/bulma#769 (comment)

Are you planning on fixing this?
It won't be a simple search & replace because some vars will be missing after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant