Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

image directive doesn't accept URL as arg #33

Open
douglatornell opened this issue Nov 5, 2021 · 2 comments
Open

image directive doesn't accept URL as arg #33

douglatornell opened this issue Nov 5, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@douglatornell
Copy link

douglatornell commented Nov 5, 2021

I am sure that an image URL is a valid argument for the image directive,
but snooty is disagreeing:
image

I've confirmed in rstspec.toml that uri is a valid arg type for figure that image inherits from, but can't see where to go from there to try to debug further.

Seeing this in version 1.11.4.dev0

@lextm lextm added the bug Something isn't working label Nov 6, 2021
@lextm
Copy link
Member

lextm commented Nov 6, 2021

The direct cause is in parser.py that argument[0].value won't work when an URI is served. But even fixing that won't allow URI as image/figure argument, as snooty has other checks that only work for path.

Thus, I don't plan to fix it at this moment.

@lextm lextm added the help wanted Extra attention is needed label Nov 6, 2021
@douglatornell
Copy link
Author

Thanks, @lextm. I appreciate the confirmation of the issue, the pointer to looking deeper into the code, and the context that it has a bigger, deeper root cause.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants