Fix <DateRangePicker /> style
#1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d66773e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
takurinton
commented
Aug 16, 2023
Comment on lines
-84
to
-91
| <Actions actions={actions} /> | ||
| <CalendarRange | ||
| startDate={startDate} | ||
| endDate={endDate} | ||
| onClose={handleClose} | ||
| onClickCloseButton={handleClickCloseButton} | ||
| onDatesChange={onDatesChange} | ||
| /> |
There was a problem hiding this comment.
actions はここで定義する必要がないので削除
props 越しで floating-ui の style を渡して、CalendarRange 側でレンダリングするように
|
before after
|
Yutan0423
approved these changes
Aug 17, 2023
これです |
|
なんかここらへんはもう少しユーザーに直感的な挙動にしたいなー（どちらの日付を選択しようとしているかを示すとか） |
|
選択している範囲より日付が早ければ、startDate側を選択、 でも2回クリックでCloseする前提であれば、ユーザー体験上よろしくない気もしますね。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#975 (comment)
ちょっと style が崩れていたので修正。
Actions を CalendarRange コンポーネント側に移した。