Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close icon for DatePicker #1370

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Add close icon for DatePicker #1370

merged 3 commits into from
Aug 16, 2023

Conversation

takurinton
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 3839895

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 3839895
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64dc935597ed520008b7e57d
😎 Deploy Preview https://deploy-preview-1370--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@takurinton
Copy link
Contributor Author

ちょいちょいスタイル変えてるから変な位置にいたりしてる

Comment on lines +20 to +24
/**
* 閉じるボタンを押したときの振る舞い
* この関数が渡されてないときは、閉じるボタンが表示されない
*/
onClickCloseButton?: () => void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

閉じるボタンを押したときの callback を追加した

@takurinton
Copy link
Contributor Author

Copy link
Contributor

@Yutan0423 Yutan0423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう
LGTM🚀

@takurinton takurinton merged commit 14912f3 into master Aug 16, 2023
1 check passed
@takurinton takurinton deleted the add-close-icon branch August 16, 2023 09:26
@FluctMember FluctMember mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants