Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmModal のキャンセルボタンの色を secondary から clear にする #1331

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

deatiger
Copy link
Collaborator

@deatiger deatiger commented Jul 11, 2023

Publisher Console の PR にて以下コメントがあり、INGRED UI 側がアップデートされていないとのことなので対応した

現在secondary buttonを使っていますが、これをclear buttonを使って実装してください。(背景色がないタイプです)

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx
  • Localize added component

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

⚠️ No Changeset found

Latest commit: 855f36d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 855f36d
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/64addb7f53387a00089945f5
😎 Deploy Preview https://deploy-preview-1331--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deatiger
Copy link
Collaborator Author

youchann or takurinton のどちらか見ていただけると mm

Copy link
Contributor

@takurinton takurinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう
changesets は無視してもらって大丈夫ですmm

@takurinton
Copy link
Contributor

自分が過去に実装しなかったっけ?とか思ったんですが、違うやつでしたmm
#724

@deatiger deatiger merged commit 2dc8131 into master Jul 12, 2023
1 check passed
@deatiger deatiger deleted the confirm-modal-cancel-button-color branch July 12, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants