Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 8 compability: rxjs 6.5.3 #26

Open
andzejsw opened this issue Oct 25, 2019 · 4 comments
Open

Angular 8 compability: rxjs 6.5.3 #26

andzejsw opened this issue Oct 25, 2019 · 4 comments

Comments

@andzejsw
Copy link

When i tried to upgrade my angular app from version 7.x to version 8.x, this error occured: Package "thruway.js" has an incompatible peer dependency to "rxjs" (requires "^5.5.12", would install "6.5.3").

@andzejsw
Copy link
Author

After i manualy installed 'rxjs' version 6.5.3, i was able to upgrade angular to version 8.2.12, but when i tried to open my app, there was this error, related to thruway.js:

TypeError: Class constructor Subject cannot be invoked without 'new'
    at new WebSocketTransport (WebSocketTransport.js:29)
    at new Client (Client.js:90)

@davidwdan
Copy link
Member

Angular 8 defaults to es2015. In tsconfig, can you try changing target to es5?

If that works, I'll look into updating the lib for es2015.

@andzejsw
Copy link
Author

andzejsw commented Nov 6, 2019

Angular 8 defaults to es2015. In tsconfig, can you try changing target to es5?

If that works, I'll look into updating the lib for es2015.

Sorry for long waiting. Yes, it works with es5. Tnx.
Please let us know, when there will be es2015 support available. And again, big thanks!

@Martin-4Spaces
Copy link

+1 for es2015 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants