-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conbench tpch .... : 'failed': True, 'return_code': 0 (exit status should reflect error) #134
Comments
Do we know where |
I suspect here:
|
Ok, so that's the labs/benchmarks exit status, I think. I'm messing with how it handles errors coming back from arrowbench, so I can take a look at how it exits; I know I saw at least one place where it sets a non-zero code, but apparently it's not everywhere it should |
Well, in the first msg here it shows that the command that exited with code zero was Exit code 0 should imply 100 % success, 0 errors. Sometimes the 'result complexity' cannot be reflected in a single number, but 0 should always mean 100 % success. Different errors can be reflected with different non-zero numbers. Looking for the word "error" in its stderr was probably a workaround around its non-authoritative (useless?) exit code. |
Considering a command as 'failed' while its exit status is 0 -- that's a major maintenance burden.
The text was updated successfully, but these errors were encountered: