Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate run ID per benchmark repo instead of build #104

Open
alistaire47 opened this issue Mar 1, 2023 · 0 comments
Open

Generate run ID per benchmark repo instead of build #104

alistaire47 opened this issue Mar 1, 2023 · 0 comments

Comments

@alistaire47
Copy link
Contributor

This is a bit of work, but ideally we'd move from generating a run ID for each build to a separate one per benchmark repo (or internal to the Run in some fashion; per-call is really better than per repo in some contexts). This didn't matter before, but now benchmarks can start and finish a run, recording useful information there if something blows up, but existing runs can't be started and finished runs can't be continued, so they can't be shared across runners. For tracking we likely still want ABCI to know what all the run IDs are and pass them down instead of runners managing their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant