Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract CommandBarHistory to new Readline History class #219

Open
thehunmonkgroup opened this issue Dec 24, 2019 · 0 comments
Open

Abstract CommandBarHistory to new Readline History class #219

thehunmonkgroup opened this issue Dec 24, 2019 · 0 comments
Assignees
Milestone

Comments

@thehunmonkgroup
Copy link
Member

#212 will add the rest of the Readline shortcuts, and abstract them to a Readline class.

One thing left over from this move is that the history management still lives in command_bar.py under a CommandBarHistory class. The class is pretty generic -- add, previous, next, cleanup, across multiple commands.

So CommandBarHistory should be moved into Readline as a generic History class, probably changing the command arguments to something more generic like tag or type.

@thehunmonkgroup thehunmonkgroup self-assigned this Dec 24, 2019
@thehunmonkgroup thehunmonkgroup added this to the v2.x milestone Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant