Reuse closed m= sections in Firefox #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. AFAIR there is a reason for me to not do this that way in the past, but I cannot recall which one now. I have to take a deeper look to this. IMHO if this works it must be done for all handlers and not just for Firefox. |
jmillan
reviewed
Feb 17, 2022
src/handlers/sdp/RemoteSdp.ts
Outdated
| if (!this._firstMid) | ||
| this._firstMid = newMediaSection.mid; | ||
|
|
||
| // Append new section to the existing vector and the SDP object |
jmillan
reviewed
Feb 17, 2022
src/handlers/sdp/RemoteSdp.ts
Outdated
| this._mediaSections.push(newMediaSection); | ||
| this._sdpObject.media.push(newMediaSection.getObject()); | ||
|
|
||
| // Add it to the map |
There was a problem hiding this comment.
Same for all the added comments.
jmillan
reviewed
Feb 17, 2022
| // Recreate map | ||
| this._midToIndex.clear(); | ||
| for (idx = 0; idx < this._mediaSections.length; ++idx) | ||
| this._midToIndex.set(this._mediaSections[idx].mid, idx); |
|
I will come back to this PR next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles m= sections reuse in Firefox by synchronizing RemoteSdp with the local description regardless of where the new transceiver's section is placed by the browser.