Fix/staking #6
Merged
Fix/staking #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
approved these changes
Sep 10, 2024
Adamantios
reviewed
Sep 12, 2024
| return synced_data, Event.NEXT_CHECKPOINT_NOT_REACHED_YET | ||
| if ( | ||
| synced_data.most_voted_tx_hash is None | ||
| and synced_data.is_staking_kpi_met == False |
There was a problem hiding this comment.
Suggested change
| and synced_data.is_staking_kpi_met == False | |
| and synced_data.is_staking_kpi_met is False |
Comment on lines
-45
to
+46
| kpi_met_for_the_day: Optional[bool] | ||
| is_staking_kpi_met: Optional[bool] |
There was a problem hiding this comment.
Now that there are so many common attributes you can convert CallCheckpointPayload to:
@dataclass(frozen=True)
class CallCheckpointPayload(BaseTxPayload):
"""A transaction payload for the CallCheckpointRound."""
service_staking_state: int
min_num_of_safe_tx_required: Optional[int]
Comment on lines
+225
to
+229
| if ( | ||
| synced_data.most_voted_tx_hash is None | ||
| and synced_data.is_staking_kpi_met == True | ||
| ): | ||
| return synced_data, Event.STAKING_KPI_MET |
There was a problem hiding this comment.
Suggested change
| if ( | |
| synced_data.most_voted_tx_hash is None | |
| and synced_data.is_staking_kpi_met == True | |
| ): | |
| return synced_data, Event.STAKING_KPI_MET | |
| if ( | |
| synced_data.most_voted_tx_hash is None | |
| and synced_data.is_staking_kpi_met is True | |
| ): | |
| return synced_data, Event.STAKING_KPI_MET |
There was a problem hiding this comment.
In CallCheckpointRound, what if both is_staking_kpi_met and most_voted_tx_hash are None? Shouldn't we re-enter CallCheckpointRound instead?
Adamantios
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix logic to consider the service active and eligible for rewards, even if it joins in between a liveness period