feat(earn): Show daily yield rate on the pool info screen if available #6159
Conversation
| @@ -573,6 +601,22 @@ export default function EarnPoolInfoScreen({ route, navigation }: Props) { | |||
| tokensInfo={tokensInfo} | |||
| earnPosition={pool} | |||
| /> | |||
| {!!dataProps.dailyYieldRatePercentage && dataProps.dailyYieldRatePercentage > 0 && ( | |||
There was a problem hiding this comment.
probably fine, but should we check its >= 0.00005? so we don't end up showing 0.0000 with the round with toFixed?
There was a problem hiding this comment.
This file is nearing 1000 lines.. I was thinking of breaking this up, I am already putting the safety card in a different file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6159 +/- ##
==========================================
- Coverage 88.77% 88.76% -0.02%
==========================================
Files 727 727
Lines 30786 30803 +17
Branches 5631 5636 +5
==========================================
+ Hits 27331 27342 +11
- Misses 3258 3264 +6
Partials 197 197
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
#6159) ### Description https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev https://linear.app/valora/issue/ACT-1406/daily-rate * Daily yield rate in pool info screen when available * small style fix to learn more link #### Daily Yield Rate https://github.com/user-attachments/assets/9ad04f6c-a06c-4e49-9af5-a9d8c6a2d1f7 #### Link Style https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/1a9e19cd-48c2-4eb9-ba67-23a864232343" width="250px"> | <img src="https://github.com/user-attachments/assets/05afb6d8-59c3-4786-b4f7-368828b1f667" width="250px"> | ### Test plan Unit tests and manually verified ### Related issues https://linear.app/valora/issue/ACT-1406/daily-rate
Description
https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev
https://linear.app/valora/issue/ACT-1406/daily-rate
Daily Yield Rate
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-16.at.12.44.26.mp4
Link Style
https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=7514-85993&node-type=instance&m=dev
Test plan
Unit tests and manually verified
Related issues
https://linear.app/valora/issue/ACT-1406/daily-rate