Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize build process during CI #1123

Open
madolson opened this issue Oct 3, 2024 · 4 comments · May be fixed by #1128
Open

Parallelize build process during CI #1123

madolson opened this issue Oct 3, 2024 · 4 comments · May be fixed by #1128
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated

Comments

@madolson
Copy link
Member

madolson commented Oct 3, 2024

When building the process, we can use multiple cores with -j. See

run: make all-with-unit-tests SERVER_CFLAGS='-Werror' BUILD_TLS=yes
.

We can hardcode it based off the known number of cores based off of the runner, we could also look into dynamically discovering the number of cores.

@madolson madolson added help wanted External contributions would be appreciated good first issue Good for newcomers labels Oct 3, 2024
@zuiderkwast
Copy link
Contributor

Hard-coding it to -j4 should be a good start. @pizhenwei mentioned the CI runners have 4 cores.

@madolson madolson changed the title Paralellize buid process Parallelize build process during CI Oct 4, 2024
@madolson
Copy link
Member Author

madolson commented Oct 4, 2024

Hard-coding it to -j4 should be a good start. @pizhenwei mentioned the CI runners have 4 cores.

MacOS have 3 or 4 cores. Also, I thought linux had 4, but the official documentation says 2. https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners

@Shivshankar-Reddy
Copy link
Contributor

Shivshankar-Reddy commented Oct 4, 2024

There are 2 section in the documenation: for public repositories, linux has 4 and private its 2. As valkey is public repo so linux should have 4.

public repo: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

private repo: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for--private-repositories

@Shivshankar-Reddy
Copy link
Contributor

I can create a PR for hard coding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted External contributions would be appreciated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants