Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW]Skip the wrong configuration #1090

Open
polaris-alioth opened this issue Sep 30, 2024 · 4 comments
Open

[NEW]Skip the wrong configuration #1090

polaris-alioth opened this issue Sep 30, 2024 · 4 comments

Comments

@polaris-alioth
Copy link

The problem/use-case that the feature addresses

When we use the generated valkey.conf, sometimes the alkey.conf is damaged and the service cannot be started.

Description of the feature

Our primary goal is to start valkey, can i add a startup parameter, skip the wrong configuration?

@enjoy-binbin
Copy link
Member

you don't want to fix the conf before you start the server? why?

in this case, is this a newly started service? Or are you restarting an old service?

@polaris-alioth
Copy link
Author

you don't want to fix the conf before you start the server? why?

in this case, is this a newly started service? Or are you restarting an old service?

Our valkey.conf is generated by a script, and the service is started by Docker. Some parameters in valkey.conf are incorrect due to various reasons. Our hope is that the service will be up and running first. Follow-up repair can be found through monitoring logs.

@hwware
Copy link
Member

hwware commented Oct 1, 2024

For some immutable config parameters, such as tcp-backlog or cluster-port, how you can deal with it? Assume the cluster-port is written as cluster-ports incorrect, then you skip it, then how you can correct it?
A little bit confused

@melroy89
Copy link
Contributor

melroy89 commented Oct 2, 2024

If server admins just want to know if something is wrong with their config, you can't just simply guess and continue with an invalid confg.

If the message is unclear if something is wrong, that is a valid request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants