Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate messages in pubsub/gossipsub rpcHandler #524

Closed
dryajov opened this issue Feb 9, 2021 · 1 comment
Closed

Deduplicate messages in pubsub/gossipsub rpcHandler #524

dryajov opened this issue Feb 9, 2021 · 1 comment
Labels
gossipsub optimization

Comments

@dryajov
Copy link
Contributor

dryajov commented Feb 9, 2021

Currently, we're deduplicating messages per message type, for example iHave, we should deduplicate messages once in the RPC handler. Additionally, it makes sense to re-evaluate scoring for peers sending large number of duplicates.

A related issues has been identified in #400.
@dryajov dryajov changed the title Deduplicate messages in rpcHandler Deduplicate messages in pubsub/gossipsub rpcHandler Feb 9, 2021
@Menduist
Copy link
Contributor

We are now more strict about peers sending duplicates (#920)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gossipsub optimization
Projects
nim-libp2p
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dryajov @Menduist