Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PrepBot #21

Open
martintb opened this issue Mar 12, 2021 · 0 comments
Open

refactor: PrepBot #21

martintb opened this issue Mar 12, 2021 · 0 comments

Comments

@martintb
Copy link
Collaborator

martintb commented Mar 12, 2021

The prepbot systems needs to be refactored on a number of levels. In particular, these changes should be made so that much of the mixing calculations can be moved to the OT2Server

  • Prepbot should understand the difference between solutes and solvents and obey common lab prep conventions
    • e.g., removing a fixed volume of a solvent + solute mixture
  • users shouldn't have to instantiate components. These should be made automatically and inferred.
    • Context manager for mixing calculation?
    • Component properties can come from database or be queried (solvents need density, density is needed for SLD)
  • Units should be required, but perhaps automatically added?
  • Mass fraction setting should only require n-1 components
@martintb martintb changed the title refactor: refactor: PrepBot Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant