Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors should fail builds #149

Closed
shreddedbacon opened this issue Jul 14, 2022 · 1 comment
Closed

errors should fail builds #149

shreddedbacon opened this issue Jul 14, 2022 · 1 comment

Comments

@shreddedbacon
Copy link
Member

In most cases of the controller handling a build, any error encountered after the build has been accepted should result in the build failing.

Currently the behaviour of the controller is to try and reconcile again which results in the error. Failing builds would be more appropriate, and sending a build log message with a brief description of what went wrong to aid in support troubleshooting.

@shreddedbacon
Copy link
Member Author

closing as duplicate of #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant