Hangs on "waiting on funds" even if tank request clearly fails

[Fang-]

Observing this in the case where the gas tank is offline, this might also happen if the gas tank refuses your request:

(Specifically, on the version of Bridge from #221, while doing invite sending, but iirc this has been reported in other contexts also.)

The UI stays on "waiting for funds" even though the browser console has already said "tank: funding failed". This should be communicated to the user immediately, as per waitForBalance()'s askForFunding.

[shrugs]

@Fang- what's the original thought behind the check here: https://github.com/urbit/bridge/blob/mino/src/lib/tank.js#L60 since afaik point is always known?

[shrugs]

this looks like it's actually intentional behavior in the code. the flow for ensureFundsFor basically says "try tank and if fail call waitForBalance" which means the tank can fail and the user should provide their own funds. which scenario is is not ideal?

[Fang-]

Yeah we really should just require/assume point there.

this looks like it's actually intentional behavior in the code.

To clarify, when I said this:

The UI stays on "waiting for funds" even though the browser console has already said "tank: funding failed". This should be communicated to the user immediately

I meant showing a "pls fund manually" message alongside the "awaiting funds" status, when this happens.

[shrugs]

ah, in that case, is the askForFunds from waitForBalance not called basically immediately (at least, after checking the address balance, which should be pretty quick)? Seems like the console would print and then we'd do the balance fetch and then set askForFunds right afterwards