Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unlock-app): showing the prime status in menu #14835

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(unlock-app): showing the prime status in menu #14835

merged 3 commits into from
Oct 10, 2024

Conversation

julien51
Copy link
Member

@julien51 julien51 commented Oct 10, 2024 •
edited
Loading

Description

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@julien51 julien51 requested a review from 0xTxbi October 10, 2024 20:20
@cla-bot cla-bot bot added the cla-signed label Oct 10, 2024
@julien51
Copy link
Member Author

Screenshot 2024-10-10 at 4 21 03 PM Screenshot 2024-10-10 at 4 25 03 PM

@julien51 julien51 requested a review from ccarfi October 10, 2024 20:25
0xTxbi
0xTxbi approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@0xTxbi 0xTxbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julien51 julien51 merged commit c93e53c into master Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTxbi 0xTxbi 0xTxbi approved these changes

@ccarfi ccarfi Awaiting requested review from ccarfi

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien51 @0xTxbi