Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onHasRole hook #14562

Open
julien51 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #14829
Open

onHasRole hook #14562

julien51 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #14829
Assignees
@clemsos
Labels
next publicLock smart contract Smart contract related issue or task

Comments

@julien51
Copy link
Member

julien51 commented Sep 3, 2024

The lock contract includes multipel roles, including lock manager or key granter. The lock contract also includes multiple hooks, and I suggest adding another one to "delegate" checking a role that we could call onHasRole.
This hook would call a function hasRole(role,address) to check if an address has this role or not.

https://docs.unlock-protocol.com/core-protocol/public-lock/access-control
@julien51 julien51 added smart contract Smart contract related issue or task next publicLock labels Sep 3, 2024
@clemsos clemsos linked a pull request Oct 9, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemsos clemsos

Labels
next publicLock smart contract Smart contract related issue or task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(smart-contracts): add hasRole hook unlock-protocol/unlock
2 participants
@julien51 @clemsos