Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let lock managers edit checkout URL #14248

Open
julien51 opened this issue Jul 9, 2024 · 2 comments · May be fixed by #14833
Open

Let lock managers edit checkout URL #14248

julien51 opened this issue Jul 9, 2024 · 2 comments · May be fixed by #14833
Assignees

Comments

@julien51
Copy link
Member

julien51 commented Jul 9, 2024

Right now, we use the createdBy field on a checkout URL to list them and/or enable edits.
Instead of relying on this mechanism for "access control" we should use lock managers.

@julien51 julien51 assigned 0xTxbi and unassigned SVell Aug 19, 2024
@julien51
Copy link
Member Author

julien51 commented Aug 20, 2024

We will likely need to solve this in 2 steps:

  1. Let a lock manager "save" a config for which they are not the creator, but for which they are lock manager on one of the locks. This will first require changes in locksmith, and then changes in the UI
  2. List configs that were not created by a user, but for which the user is a lock manager on one of the locks.

The checkout URL builder already supports passing a checkout config id in its URL like https://app.unlock-protocol.com/locks/checkout-url?id=3f2ee0bd-077f-4c8b-bd11-85038692006e . this will make it easier to work on the 1st step.
If the 2nd step is too complicated (listing configs for which one of the lock's is managed by the current user) is going to be wasteful, then we can take an intermediate of allowing the user to enter a custom checkout id in the step to select an existing checkout id.

@0xTxbi
Copy link
Member

0xTxbi commented Aug 20, 2024

got it!

@0xTxbi 0xTxbi linked a pull request Oct 10, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants