Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would this project accept PR with ids for GPO's Pictorial API #942

Open
kevinschaul opened this issue Sep 3, 2024 · 2 comments · May be fixed by #943
Open

Would this project accept PR with ids for GPO's Pictorial API #942

kevinschaul opened this issue Sep 3, 2024 · 2 comments · May be fixed by #943

Comments

@kevinschaul
Copy link

I am working on updating a script in unitedstates/images, and it involves matching legislators with their GPO Pictorial API ids. (Unfortunately that API does not include Bioguide IDs.) There are some tricky cases, and so I think the join will require a manual lookup for some legislators with common names. That makes me think the lookup might work well in this repo instead.

Would this repo accept a PR with these ids, and a script to help generate them automatically?

My WIP script is here. Happy to transfer it to this repo if you all think that makes sense.
@dwillis
Copy link
Member

dwillis commented Sep 3, 2024

@kevinschaul I think this would be very nice to have, yes, and I'd also like to push the GPO to add bioguide IDs separately.

@kevinschaul
Copy link
Author

Thanks @dwillis, I'll get a PR started.

kevinschaul added a commit to kevinschaul/congress-legislators that referenced this issue Sep 3, 2024
@kevinschaul
Add pictorial ids, script for 118th Congress
283d65e 
Adds ids mapping to GPO's Pictorial Member Guide
pictorialapi.gpo.gov

This PR includes ids for all members of 118th Congress. It may also work
for historical files -- at least going back to 110 -- but I have not
included that work here, as it requires manual fixes and I imagine most
interest is in current membership.

Closes unitedstates#942
@kevinschaul kevinschaul linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pictorial ids, script for 118th Congress kevinschaul/congress-legislators
2 participants
@dwillis @kevinschaul