Delete disabled hosts

[paalbra]

Hosts are currently just disabled when removed and not deleted. This will lead to piling of disabled hosts.

zabbix-auto-config/zabbix_auto_config/processing.py

Lines 496 to 501 in 9ff0b81

	for hostname in hostnames_to_remove:
	if self.stop_event.is_set():
	logging.debug("Told to stop. Breaking")
	break
	zabbix_host = zabbix_hosts[hostname]
	self.disable_host(zabbix_host)

zabbix-auto-config/zabbix_auto_config/processing.py

Lines 404 to 413 in 9ff0b81

	def disable_host(self, zabbix_host):
	if not self.dryrun:
	try:
	disabled_hostgroup_id = self.api.hostgroup.get(filter={"name": "All-auto-disabled-hosts"})[0]["groupid"]
	self.api.host.update(hostid=zabbix_host["hostid"], status=1, templates=[], groups=[{"groupid": disabled_hostgroup_id}])
	logging.info("Disabling host: '%s' (%s)", zabbix_host["host"], zabbix_host["hostid"])
	except pyzabbix.ZabbixAPIException as e:
	logging.error("Error when disabling host '%s' (%s): %s", zabbix_host["host"], zabbix_host["hostid"], e.args)
	else:
	logging.info("DRYRUN: Disabling host: '%s' (%s)", zabbix_host["host"], zabbix_host["hostid"])

Possible enhancement could be adding the hosts to some kind of "deathrow" group that gets deleted at a later point.

E.g. this is week 2020-W24. If a two week buffer is enough a disabled host could be added to host group DeathRow-2020-W26 and be deleted when we arrive in 2020-W26. If a host gets enabled before this week they should be removed from the "deathrow" host group.