Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate using smallvec throughout voyager #3027

Open
benluelo opened this issue Sep 26, 2024 · 0 comments
Open

investigate using smallvec throughout voyager #3027

benluelo opened this issue Sep 26, 2024 · 0 comments
Labels
A-voyager Area: Our voyager relayer C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@benluelo
Copy link
Contributor

there are many places where we have Vec<SomeSmallType> (not enumerated here), where the length is often very short (usually between 0-2). we should investigate using smallvec to prevent potentially costly allocations where we can.

requirements:

  • benchmarks/flamegraphs for comparison with current and new
@benluelo benluelo added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-voyager Area: Our voyager relayer C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-voyager Area: Our voyager relayer C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benluelo