Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: ICU-22908 MF2: Finish updating spec tests and implement required test functions #3216

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DRAFT: ICU-22908 MF2: Finish updating spec tests and implement required test functions #3216

wants to merge 2 commits into from

Conversation

catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Sep 25, 2024 •
edited
Loading

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22908
    • For minor changes you can use one of the following per-release tickets:
    • ICU 77 code warnings/version updates: ICU-22920 — Fix compiler warnings. Update versions of code-related dependencies (e.g., dependabot).
    • ICU 77 docs minor fixes: ICU-22921 — User Guide & API docs typos etc., and version updates (e.g., dependabot for User Guide)
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@catamorphism
ICU-22908 MF2: Update spec tests and update implementation for recent…
534dd57 
… spec changes

Updating the spec tests requires two implementation changes:
* Match on variables rather than expressions --
  see unicode-org/message-format-wg#877
* Require attribute values to be literals (if present) --
  see unicode-org/message-format-wg#894
@catamorphism catamorphism force-pushed the spec-updates-plus-pattern-selection branch from 2680b67 to c3902e3 Compare September 25, 2024 23:49
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2_function_registry_internal.h is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism catamorphism force-pushed the spec-updates-plus-pattern-selection branch from c3902e3 to 5f55d7c Compare September 25, 2024 23:55
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@catamorphism
ICU-22908 MF2: Finish updating spec tests and implement required test…
38500d3 
… functions

Implement :test:format, :test:select, and :test:function, which are
required by the new `pattern-selection.json` tests.

Change the internal value representation in the formatter in order to
support some of the test cases (binding the results of selectors to a
variable).
@catamorphism catamorphism force-pushed the spec-updates-plus-pattern-selection branch from 5f55d7c to 38500d3 Compare September 25, 2024 23:58
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/messageformat2.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@catamorphism