ICU-22911 Fix coverity warning in numrange_fluent.cpp #3202
Conversation
| : NFS<LNF>(std::move(src)) { | ||
| // Safely access the member from *this, which holds the moved-from state | ||
| // Steal the compiled formatter | ||
| LNF&& _src = static_cast<LNF&&>(src); | ||
| auto* stolen = _src.fAtomicFormatter.exchange(nullptr); | ||
| auto* stolen = this->fAtomicFormatter.exchange(nullptr); | ||
| delete fAtomicFormatter.exchange(stolen); |
There was a problem hiding this comment.
Good catch on use-after-move, but... now we are stealing from ourselves, and putting the stolen pointer right back where it came from??
Do we need to futz with the fAtomicFormatter at all in this move copy constructor? If that got moved, then "this" should have the right state, right?
If we do need to futz with it, then I suspect we need to do it before moving stuff from src.
@aheninger @sffc please chime in. I don't have context for how these objects are built.
There was a problem hiding this comment.
I think that the pre-existing code is completely fine. fAtomicFormatter is a field of LNF but not NFS. We read only that field, not any other fields.
There was a problem hiding this comment.
@sffc coverity complains that we are using src after it's been subject to std::move. This seems like a fair complaint.
Could we std::move just the NFS slice of src?
Could we move the formatter before moving src?
There was a problem hiding this comment.
I don't think it is a fair complaint. As far as I can tell, C++ does not offer a mechanism to mark only part of an object as having been moved (unlike Rust which provides such a mechanism). I found a thread that says that what this code is doing is the correct pattern when you have a child class calling the move constructor of a base class, although I don't know the credibility of the people responding on this thread:
| : NFS<LNF>(std::move(src)) { | ||
| // Safely access the member from *this, which holds the moved-from state | ||
| // Steal the compiled formatter | ||
| LNF&& _src = static_cast<LNF&&>(src); | ||
| auto* stolen = _src.fAtomicFormatter.exchange(nullptr); | ||
| auto* stolen = this->fAtomicFormatter.exchange(nullptr); | ||
| delete fAtomicFormatter.exchange(stolen); |
There was a problem hiding this comment.
I think that the pre-existing code is completely fine. fAtomicFormatter is a field of LNF but not NFS. We read only that field, not any other fields.
See: https://unicode-org.atlassian.net/browse/ICU-22911
Checklist