Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible feature: action icon next to search bar #144

Open
andrewkslv opened this issue Jan 14, 2018 · 5 comments
Open

Possible feature: action icon next to search bar #144

andrewkslv opened this issue Jan 14, 2018 · 5 comments

Comments

@andrewkslv
Copy link

andrewkslv commented Jan 14, 2018

I've noticed that the library doesn't have the option to set showing "+" button while not editing. It would be cool to have this one with the ability to set a color for the icon.

@andrewkslv
Copy link
Author

@iRoachie what do you think about it?

@iRoachie
Copy link
Collaborator

Seems like a very specific use case. Can you not have a container with the searchbar and your icon button next to it?

@andrewkslv
Copy link
Author

This is Reminders inbuild iOS App. So it's hard to say that it's a very specific use case. I can make a container but it takes more space on the screen to place [Search][Cancel][+]

@iRoachie
Copy link
Collaborator

Would the cancelButtonText on the next branch work for your use case?

@andrewkslv
Copy link
Author

I don't think so. I'm not forcing to implement features for my needs. I'm just offering ways to extend functionality and if it's along with my needs it's cool.

Just to clarify Remiders app states:

initial state: [Search][+]
onFocus: [Search][Cancel]
onTextExist: [Search][x][Cancel]

If we add manually [+] button it would be

initial state: [Search][+]
onFocus: [Search][Cancel][+]
onTextExist: [Search][x][Cancel]

If pass showsCancelButtonWhileEditing it would be

initial state: [Search][+]
onFocus: [Search][+]
onTextExist: [Search][x][+]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants