Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Missing mapPoint function #1

Open
waltsims opened this issue Jun 13, 2023 · 2 comments
Open

Bug: Missing mapPoint function #1

waltsims opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@waltsims
Copy link

What Happened?

mapPoint seems to be missing from the v1.4.0 release of the k-wave toolbox.

Error messages

NA

How Can We Reproduce?

I didn't run the code with kgrid.nonuniform but the method mapPoint is not listed in the repository.

Operating System

Mac

Release Version

1.4 (Default)

MATLAB Version

9.13.0.2049777 (R2022b)

@waltsims waltsims added the bug Something isn't working label Jun 13, 2023
@btreeby
Copy link
Member

btreeby commented Jun 15, 2023

Well spotted. The nonuniform grid option has never been officially supported (it’s only implemented in 1D), and currently isn’t supported by tests, which is why I missed it. I’ll take a look at migrating an old non-uniform example into the toolbox.

Is this functionality you make use of?

@btreeby btreeby closed this as completed Jun 15, 2023
@btreeby btreeby reopened this Jun 15, 2023
@btreeby btreeby self-assigned this Jun 15, 2023
@waltsims
Copy link
Author

Thank you! I am not currently using this functionality, but I stumbled across it when looking to port offGridPoints to k-wave-python, and I wanted to bring it to your attention. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants