Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor Approvals Should Not Be Considered #22

Open
0x4007 opened this issue Oct 4, 2024 · 2 comments · May be fixed by #23
Open

Contributor Approvals Should Not Be Considered #22

0x4007 opened this issue Oct 4, 2024 · 2 comments · May be fixed by #23

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 4, 2024

This doesn't make any sense to consider outsider approvals to automatically merge into our code, let alone default to 2. This logic should be removed.

In theory it could be possible to run an org with a single member using this system but seems very unusual. I would remove this logic related to considering contributor approvals.

contributor: T.Number({ default: 2, minimum: 1 }),

@YanVictorSN
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Oct 8, 2024

Deadline Tue, Oct 8, 1:34 PM UTC
Beneficiary 0xF51cFA5eb9128F064eafb75524502A039F063D91

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@YanVictorSN YanVictorSN linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants