Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated merging not working if total reviewers is under the minimum reviewer quota #16

Open
gentlementlegen opened this issue Aug 26, 2024 · 0 comments

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Aug 26, 2024

There is a scenario where a pull-request can have all the validations from the reviewers but won't get merged because the amount of reviewers is under the amount of required reviewers.

Example

A review has 2 validations out of 2 reviewers, but 3 are required.

Possible solutions

Merge when 100% of reviewers validated

Pros:

  • avoids the automated merging to be stuck
  • doesn't require multiple validations on small / simple tasks

Cons:

  • dangerous, even more for outsider pull-requests, that could be merged only with one validation
  • could be missed by the team that wouldn't notice the merging happening

Post a message saying that the PR can be merged, but requires n more reviewers

Pros:

  • safe, wouldn't automatically merge the pull-request without meeting the requirements
  • could even notify the team about the required reviews

Cons:

  • might require multiple reviews for simple tasks
  • can increase noise, and delay merging

Partially relates to #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant