Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No message is posted after a first /start #34

Closed
gentlementlegen opened this issue Sep 3, 2024 · 9 comments
Closed

No message is posted after a first /start #34

gentlementlegen opened this issue Sep 3, 2024 · 9 comments

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Sep 3, 2024

After the first /start message, no message seems to be posted if the user tries to do /start again (neither "you are already assigned" or "you cannot assign yourself again" etc.). However I do see the proper logs in Cloudflare. Not sure if that was introduced by some merge.

@Keyrxng rfc


This is only valid for the development branch not the main one.

@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 3, 2024

ubq-testing#18
ubq-testing#17

I wasn't able to reproduce a non-response but it has highlighted a couple of issues so I will open a PR to address those.

  1. The new string param is not diffed and responds in both scenarios startRequiresWallet: true & false so it appears misleading
  2. Using APP_ID to detect the bot is not suitable as the bot has it's own userId, we'd need to check installs like we do now in other repos using the private key etc. So it has to be either the bot's userId or the app_slug (i.e it's name)

Which option would be best, user_id or name? I think name is more appropriate as this is tied to the app_slug which is universal across all installs and does not require using injecting APP_PRIVATE_KEY in order to pull installs to match userId? @0x4007 @gentlementlegen

My mistake in allowing this to merge without noticing was that I updated my APP_ID in .env and not .dev.vars. This may have had something to do you what you experienced @gentlementlegen but still I couldn't produce a non-response

This was referenced Sep 3, 2024
@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 3, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Sep 3, 2024

! You have reached your max task limit

@keyrxng2
Copy link

keyrxng2 commented Sep 3, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Sep 3, 2024

! No price label is set to calculate the duration

@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 3, 2024

I'm pretty sure the current deployment is coming from development

It's not, it's coming from main

@0x4007
Copy link
Member

0x4007 commented Sep 3, 2024

usernames should be forbidden. use user id, or "app id"

@gentlementlegen
Copy link
Member Author

Seems to be working so far.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Copy link
Contributor

ubiquity-os bot commented Sep 24, 2024

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants