Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The extension failed to load properly. It might not be able to intercept network requests. #199

Closed
TESTER-sec opened this issue Sep 6, 2024 · 11 comments
Labels

Comments

@TESTER-sec
Copy link

image

image

@gorhill
Copy link
Member

gorhill commented Sep 6, 2024

Do you have other content blocking extensions installed -- disabled included?

@garry-ut99
Copy link

garry-ut99 commented Sep 6, 2024

A duplicate of:

(Don't spam with duplicates, next time post in already existing threads, search issue tracker before creating a new thread (and in case you already did it, do it better next time)).

@TESTER-sec
Copy link
Author

Do you have other content blocking extensions installed -- disabled included?

No. Just uBOL.

A duplicate of:

(Don't spam with duplicates, next time post in already existing threads, search issue tracker before creating a new thread (and in case you already did it, do it better next time)).

Uhm, I did not spam anything., I did search and saw issue 109, but it was closed. I do not make reports to closed reports.

Be better, instead of being a jackass to people that are giving you their free time to help your project.

@garry-ut99

This comment was marked as off-topic.

@gorhill

This comment was marked as off-topic.

@gorhill
Copy link
Member

gorhill commented Sep 6, 2024

No. Just uBOL.

Given this, I will confirm this as duplicate of #109. Sometimes when the extension updates there is an "internal error" reported at the console. Restarting the extension fixes the issue. This is out of control of uBOL, as the error occurs somewhere in the browser's extension framework.

@gorhill gorhill closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
@MasterKia MasterKia added the duplicate This issue or pull request already exists label Sep 6, 2024
@gorhill gorhill reopened this Sep 6, 2024
@gorhill
Copy link
Member

gorhill commented Sep 6, 2024

Actually, given more thoughts, since uBOL should be able to detect the error condition, I will add code to force a restart the extension when such detection occurs. Whether this works or not is purely a guess, will find out with time if this makes such reports go away.

@garry-ut99

This comment was marked as off-topic.

@garry-ut99

This comment was marked as off-topic.

@TESTER-sec

This comment was marked as off-topic.

@uBlockOrigin uBlockOrigin locked as resolved and limited conversation to collaborators Sep 7, 2024
@gorhill
Copy link
Member

gorhill commented Sep 22, 2024

I was able to reproduce the issue in my local build as I prepared for a new release.

The previously committed code didn't work as expected, and since I was to reproduce at will (as long as a force-reload of the extension was not performed), I could test the code which purpose is to work around the issue. So this is confirmed fixed with gorhill/uBlock@ff57f01.

@MasterKia MasterKia added fixed and removed duplicate This issue or pull request already exists labels Sep 22, 2024
@gorhill gorhill closed this as completed Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants