Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK AWS module: resource detectors, X-Ray propagator, X-Ray sampler #744

Closed
iRevive opened this issue Aug 31, 2024 · 3 comments
Closed

SDK AWS module: resource detectors, X-Ray propagator, X-Ray sampler #744

iRevive opened this issue Aug 31, 2024 · 3 comments
Assignees
@iRevive
Labels
help wanted Extra attention is needed sdk contrib aws Feature and improvements to the sdk contrib module sdk module Features and improvements to the sdk module

Comments

@iRevive
Copy link
Contributor

iRevive commented Aug 31, 2024 •
edited
Loading

https://opentelemetry.io/docs/specs/otel/resource/sdk/

Custom resource detectors related to generic platforms (e.g. Docker, Kubernetes) or vendor specific environments (e.g. EKS, AKS, GKE) MUST be implemented as packages separate from the SDK.

Currently, there are three different components:

  1. Resource detectors - such as Beanstalk, EC2, ECS, EKS, Lambda
  2. [trace] X-Ray propagator
  3. [trace] X-Ray IDGenerator and Sampler

Dependencies-wise, the situation is following:

  1. Resource detectors - depends on otel4s-sdk-core, also requires http4s.EmberClient
  2. X-Ray propagator - depends on otel4s-sdk-core
  3. X-Ray IDGenerator and Sampler - depends on otel4s-sdk-trace, requires http4s.EmberClient

OpenTelementry Java organizes packages in the following way:

  1. Resource detectors - io.opentelemetry.contrib.aws.resource
  2. X-Ray propagator - io.opentelemetry.contrib.awsxray.propagator
  3. X-Ray IDGenerator and Sampler - io.opentelemetry.contrib.awsxray

We can follow the pattern too:

  1. Resource detectors - otel4s-sdk-contrib-aws-resource-detectors
  2. X-Ray propagator - otel4s-sdk-contrib-aws-xray-propagator
  3. X-Ray IDGenerator and Sampler - otel4s-sdk-contrib-aws-xray
@iRevive iRevive added the sdk module Features and improvements to the sdk module label Aug 31, 2024
@iRevive iRevive mentioned this issue Aug 31, 2024
Merged
@iRevive
Copy link
Contributor Author

iRevive commented Sep 1, 2024 •
edited
Loading

Resource detectors:

@iRevive
Copy link
Contributor Author

iRevive commented Sep 1, 2024 •
edited
Loading

Text map propagators:

@iRevive iRevive added the help wanted Extra attention is needed label Sep 9, 2024
@iRevive iRevive self-assigned this Sep 13, 2024
@iRevive iRevive added the sdk contrib aws Feature and improvements to the sdk contrib module label Sep 18, 2024
@iRevive
Copy link
Contributor Author

iRevive commented Sep 18, 2024

Closing in favor of: #784 and #783.

@iRevive iRevive closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iRevive iRevive

Labels
help wanted Extra attention is needed sdk contrib aws Feature and improvements to the sdk contrib module sdk module Features and improvements to the sdk module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iRevive