Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssml tags are capitalized causing errors on twillio ml apps #207

Open
comsma opened this issue Jul 13, 2023 · 8 comments
Open

ssml tags are capitalized causing errors on twillio ml apps #207

comsma opened this issue Jul 13, 2023 · 8 comments
Labels
status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@comsma
Copy link

comsma commented Jul 13, 2023

Issue Summary

The twiml.VoiceProsody struct does not generate the right xml tag for prosody. ssml docs

Steps to Reproduce

  1. create a new struct for twiml.VoiceProsody
  2. observe that the tag is and not as per twillio documentation

Technical details:

  • twilio-go version: v1.10.0
  • go version: 1.20
@AsabuHere AsabuHere added status: help wanted requesting help from the community type: bug bug in the library labels Jul 14, 2023
@AsabuHere
Copy link
Contributor

Hi @comsma, Thank you for the heads up! This issue has been added to our internal backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.

Thanks,
Athira

@abhishek-eltropy
Copy link

abhishek-eltropy commented Oct 10, 2023

Facing Warning 12200
Message: XML Validation warning

For SSML Tags e.g.
"Break" should be "break"
"S" should be "s"

Do we have ETA for the fixes? @AsabuHere

@abhishek-eltropy
Copy link

abhishek-eltropy commented Oct 10, 2023

@twilio Should we use twilio-go sdk for production ?
Or this library is still in beta ?

@AsabuHere
Copy link
Contributor

AsabuHere commented Oct 11, 2023

We are working on this issue in the current sprint https://issues.corp.twilio.com/browse/DII-1185. Since these files are auto generated the above PR would not work. This need another PR to yoyodyne repo which generates these files. Otherwise these changes will be overwritten in the next release. The yoyodyne changes needs a detailed analysis and more work which may take some more time. We will keep this thread posted about the progress

@AsabuHere AsabuHere added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Oct 11, 2023
@AsabuHere
Copy link
Contributor

Hi @comsma, Can you please provide detailed steps on how to reproduce this issue? Please share a sample code snippet where this is used and what usage caused this exact error

Thanks,
Athira

@AsabuHere
Copy link
Contributor

Hi @comsma Any updates on this issue?

@PhilThurston
Copy link

@AsabuHere Detailed steps to reproduce were provided several days before (Oct 11, 2023) your last response to this issue in #221 where you asked for steps as well. It seems strange that you would follow-up to ask for them again. You said back on Oct 11, 2023 that it would slated for that current sprint. The relevant code on how to reproduce this was provided. Are there any further updates on when this will be resolved. From my understanding that sprint you had mentioned has come and gone.

It may be prudent to merge in the various pull requests that fix this issue until the twilio team can get around to resolving this long-standing issue.

@comsma
Copy link
Author

comsma commented Jan 23, 2024

@AsabuHere is there a new release that fixes the VoiceProsody tag?there was no communication in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Development

No branches or pull requests

4 participants