Directory elimination

[tslocum]

Issue by cristianpark
Sunday Sep 30, 2012 at 01:11 GMT
Originally opened as sole#42

---

Hi, I just found the project some days ago and I love it since I hadn't any other reliable way for connecting my Samsung Galaxy S3 to my linux box. However I found that when you try to remove a directory, it just stay there (I tried with . prefixed directories) and I see in console: EXECUTE= adb shell rm /mnt/sdcard/.skynet, I think you missed the -r option there, so I go and search for execution instruction on files and found this (on src/Aafm.py):
self.execute('%s shell rm %s' % (self.adb, self.device_escape_path(path)))
and I replaced with:
self.execute('%s shell rm -r %s' % (self.adb, self.device_escape_path(path)))
and it works just fine but I can't find a way to commit the change to github (other than clone the repo) so I create this ticket for you to update your code

Thanks for your time and effort with this application

[tslocum]

Comment by sole
Sunday Sep 30, 2012 at 10:51 GMT

---

Thank you! Glad the project is helping you :-)

So the directories you wanted to delete weren't empty then?

If you want to contribute code, yes, that's the way it should work: fork the code, make the changes, push them to your fork and submit a pull request.

[tslocum]

Comment by cristianpark
Sunday Sep 30, 2012 at 19:25 GMT

---

Hi sole, indeed the directories aren't empty. I'm new to github but I'll give it a try for submit my changes.

Thanks

[tslocum]

Comment by sole
Sunday Sep 30, 2012 at 20:12 GMT

---

Thanks for the information!

It's OK you being new to github, just experiment and learn, there's no rush :-)
That way your contribution gets recognised in the project. It's just nice! And you can use that knowledge to contribute to more projects in the future!