Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example of server-side events in controllers.md #2759

Closed
wants to merge 1 commit into from

Conversation

IvaDey
Copy link
Contributor

@IvaDey IvaDey commented Jul 22, 2024

Information

Type Breaking change
Doc No

Todos

  • Documentation

@Romakita
Copy link
Collaborator

Hello @IvaDey

Thanks a lot for this PR :D and I'm sorry for this late reply. I worked on a new feature for Ts.ED based on your PR documentation.

I think we need to provide a more robuste module because the given example is probably not compatible with Koa. So added in SSE example in the doc section doesn't follows the Ts.ED philosophy to provide a cross platform code exemple ^^.
But you couldn't really know that when you were editing the documentation.

I would to work together on this PR, that add a new @tsed/sse module to configure the server automatically and to provide an official Ts.ED API to implement SSE:
#2763

This a draft, but I think it will be awesome to have it for all Ts.ED developers.

While waiting for this PR to move forward, we can just move your code to the tutorial section of the documentation.

We can also indicate that the example is not compatible with Koa and that a solution is being developed to provide official SSE support ;)

See you @IvaDey and thank again for your involvement!

@Romakita Romakita force-pushed the production branch 4 times, most recently from b76e7c8 to 9230a2a Compare August 25, 2024 08:18
@IvaDey
Copy link
Contributor Author

IvaDey commented Oct 15, 2024

Sorry, missed notifications(

But seems this PR is not rellevant more due #2763

@IvaDey IvaDey closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants